github_pr_tree icon indicating copy to clipboard operation
github_pr_tree copied to clipboard

Published 20 hours ago • verified publisher icon berzniz

File tree doesn't strikethrough name of empty file that was deleted

Open t1m0thyj opened this issue 2 years ago • 3 comments

First, thank you for making this extension! It makes reviewing PRs a much better experience 🙂

In this PR an empty file .eslintrc was removed. In the file tree, the name should be crossed out but isn't: image

For other non-empty files that were deleted in the PR, their names are crossed out as expected.

t1m0thyj avatar Aug 13 '21 17:08 t1m0thyj

Thanks for reporting, but the .eslintrc file is not deleted, it exists but has no content (file is empty): image

While we could also strikethrough empty files, I believe it is not a good depiction of the diff state.

Closing for now.

berzniz avatar Jan 07 '22 09:01 berzniz

@berzniz The file is deleted in the PR that I linked: eslint-deleted

Prior to the PR, .eslintrc was an empty file in the repository. In the PR, the empty .eslintrc file was deleted.

I am not suggesting strikethrough for all empty files, but only for empty files that have been deleted. Could you please consider reopening this issue?

t1m0thyj avatar Jan 10 '22 13:01 t1m0thyj

Thanks @t1m0thyj, this makes sense now. Thanks for the detailed explanation. A fix should be pretty simple here

berzniz avatar Jan 10 '22 22:01 berzniz