[Feature Request] Display comments left on old commits

[thombet]

Hello,

First of all thanks for the great work on this extension: it really makes pull requests better in GitHub 😃

Nevertheless I have been struggling when reviewing code on GiHub since the beginning because of the use case described here: https://stackoverflow.com/q/44227100

Is there a way to make the handling of this use case better by adding a new feature in this extension?

Thanks in advance!

[berzniz]

Thanks @thombet for the suggestion.

The extension currently works by collecting information from the page itself (by reading the DOM). If the outdated comments information is not there, it will require a change in how the extension collects the information (maybe using API calls).

If anyone wants to take a try, I would accept a PR fort his. Worth detailing first what you're planning to achieve.

[thombet]

I'm almost sure this information is not in the DOM otherwise GitHub would probably display it already. Unfortunately I would not be able to help implementing this...

If it helps, I think the use case is very well described in the link above. In a nutshell he solution I'm looking for is to be able to display the comments that were posted on a specific commit in the "Flies changed" view of a PR, even if they are outdated.

Coming from Gerrit, I'm quite surprised that neither GitHub nor any extension implemented this already as it really ensure you check all the review comments.