beryx
fix #153 (JDK 21+ compatibility)
This PR fixes #153:
- update ASM to 9.7 (already "knows" about Java 23 and will probably work with that version once it's released)
- update Gradle wrapper to 8.9 (I still can compile with JDK 11, so I hope that's fine)
- update all other dependencies to the latest versions (except the log4j version in the samples; and not requiring groovy 4)
Ah this is why it wasn't working with 21. Why no merge yet after 3 months?
@PerryCameron I think the original maintainer, @siordache, simply does not have time to regularly update the project anymore. He asked for co-maintainers a while ago and someone stepped up, but it seems that person also has abandoned the project.
I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).
I didn't step up as a co-maintainer back then because this project is mainly Groovy and I am really a noob in that language, but maybe I should have. In the meantime, I have volunteered to become a co-maintainer, but @siordache did not reply yet.
I currently have a patched version of the plugin installed locally that fixes this and an issue with kotlin build files and am thinking of forking this and publishing an updated version to plugin central (and of course continue to stream any patches upstream in case this repo gets active again).
That sounds very promising 👍, Thanks! Did you do so already?
@danielpeintner I have released a patched version of the plugin to plugin central. To use it, change the plugin id in your gradle build script fom org.beryx.runtime to com.dua3.gradle.runtime and if you also need the plugin version, I bumped it from 1.13.1 to 1.13.1-patch-1. I ha ve tested it with my own JDK 21 project, but JDK 23 should probably work too.
Please report back if something doesn't work.
And if it's of interest to anyone, I have done the same for the sister-plugin Badass-Jlink-Plugin.
Sources for my patched version of the plugin: https://github.com/xzel23/badass-runtime-plugin Sources for the JLink plugin: https://github.com/xzel23/badass-jlink-plugin
Please report back if something doesn't work.
Thank you a lot! It worked nicely 👍. FYI: I am using JDK21.
I got co-maintainer status on this project from @siordache some years ago, but I have been too busy with other projects and have not worked with JavaFX in years. If anyone else want to step up and help maintain this plugin that would be great, but I think only @siordache have access to add co-maintainers.
I will take a look at this PR. If I still have access as maintainer, I will merge this fix.
I got co-maintainer status on this project from @siordache some years ago, but I have been too busy with other projects and have not worked with JavaFX in years. If anyone else want to step up and help maintain this plugin that would be great, but I think only @siordache have access to add co-maintainers.
Hi @DJViking, sorry, I have been really busy (like always), but I think I could step in here and do some maintenance work on this plugin. I do the same for its sibling, i.e., the jlink plugin by the same author.
Hi @siordache, I think I could also help out a bit with this plugin. If you are okay with this, I volunteer to become a co-maintainer.
@xzel23 could you please remove the last 3 commits from this pr so it can be merged?
Hi @xzel23 , sorry for overlooking your previous request. I have now sent you an invitation to become a co-maintainer.
Thank you @siordache. I think I'll have some time on the weekend to make the plugin Java 25 ready (and hopefully Gradle 9).
@masterflitzer I'll look into this on the weekend. I think the current PR might be somewhat outdated.