beryx
feat: Fix missing jmods folder
Partially fixes https://github.com/beryx/badass-jlink-plugin/issues/299 At least it makes it so that you can compile again.
Thank you, I'll test it maybe on the weekend before integrating and spinning a release.
Thank you, I'll test it maybe on the weekend before integrating and spinning a release.
Do you need an extra pair of hands with the maintenance of this project? Happy to help. Just let me know if need be.
Hi @CodeDead, thank you for the suggestion! The reason I have not yet merged the PR yet is that we first need a test case for this. You could indeed help. I'll attach a patch where I started working on a test case (without your changes applied). That should work with a pre-JEP 493 JDK. But it fails for whatever reason I did not yet find the time to investigate. After fixing that, the next steps are:
- add toolchain to the helofx-jep493 test build file, and use the foojay toolchain resolver to automatically install the required temurin JDK 24 toolchain for the build. This should break then the build.
- When the breakage is confirmed, add your changes. If now the build passes, this can be merged.
If you are willing to follow these steps to update your PR, this would be a great help as I am currently really busy with multiple projects.
It doesn't matter. You can put it into a single PR. Just use separate commits.
Sorry, could not get back to you sooner. Have been dealing with a severe covid case and am still healing. Will try to do this when I am able.