badass-jlink-plugin icon indicating copy to clipboard operation
badass-jlink-plugin copied to clipboard

Cannot set distinct launcher name and image name

Open HGuillemet opened this issue 11 months ago • 3 comments

When specifiying both imageName in jpackage data and name in launcher, the launcher name is ignored and the image name is used instead.

Sample project reproducing the issue: name-ignored.tgz

HGuillemet avatar Jan 29 '25 08:01 HGuillemet

I just found this bug report having the same issue. The following simplified example produces an Installer named "C", and binaries named "C" and "B". "A" is ignored.

jlink {
  launcher {
    name = "A"
  }
  secondaryLauncher {
    name = "B"
  }
  jpackage {
    imageName = "C"
  }
}

niabot avatar Feb 04 '25 11:02 niabot

Yes, thank you. I didn't find the time yet. I need to create an example that goes into the regression tests of the plugin first. I am currently still on another project and hopefully can finish that task this week so I can look into this.

xzel23 avatar Feb 05 '25 08:02 xzel23

First of all thanks again for providing a working example project, this makes it much easier to work on the issue.

I have looked into this. The problem is that the jpackage command line does not support setting different launcher and image names directly. So if another launcher name is requested, a properties file has to be created. This is currently only done for secondary launchers. So this is a little bit more complicated than I thought. This might take some time because I am currently very busy with my day job and some refactoring and testing needs to be done so that nothing breaks. It's on my todo list.

xzel23 avatar Feb 24 '25 10:02 xzel23