go-orbit-db icon indicating copy to clipboard operation
go-orbit-db copied to clipboard

WIP fix: close of stores

Open D4ryl00 opened this issue 3 years ago • 1 comments

Close store correctly with their goroutines

Signed-off-by: D4ryl00 [email protected]

D4ryl00 avatar Sep 13 '22 08:09 D4ryl00

Codecov Report

Base: 63.82% // Head: 62.82% // Decreases project coverage by -0.99% :warning:

Coverage data is based on head (d4c07a8) compared to base (b503985). Patch coverage: 65.16% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   63.82%   62.82%   -1.00%     
==========================================
  Files          36       35       -1     
  Lines        2485     2515      +30     
==========================================
- Hits         1586     1580       -6     
- Misses        620      643      +23     
- Partials      279      292      +13     
Flag Coverage Δ
unittests 62.82% <65.16%> (-1.00%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stores/basestore/base_store.go 59.02% <59.20%> (-1.96%) :arrow_down:
baseorbitdb/orbitdb.go 71.20% <88.46%> (+2.99%) :arrow_up:
messagemarshaler/json_marshaler.go 100.00% <100.00%> (ø)
pubsub/oneonone/channel.go 71.26% <100.00%> (-2.55%) :arrow_down:
pubsub/pubsubraw/pubsub.go 79.41% <100.00%> (+0.62%) :arrow_up:
stores/documentstore/document.go 46.21% <100.00%> (ø)
stores/eventlogstore/log.go 69.38% <100.00%> (ø)
stores/events.go 100.00% <100.00%> (ø)
stores/kvstore/keyvalue.go 45.94% <100.00%> (ø)
pubsub/pubsubcoreapi/pubsub.go 70.12% <0.00%> (-10.39%) :arrow_down:
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 13 '22 08:09 codecov[bot]

:tada: This PR is included in version 1.19.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Nov 17 '22 16:11 github-actions[bot]