ansible-role-bind icon indicating copy to clipboard operation
ansible-role-bind copied to clipboard

Remove unnecessary extra variable

Open rowanthorpe opened this issue 4 years ago • 1 comments
trafficstars

A variable host_all_addresses already exists (created in tasks/zones.yaml) for "the union of Ansible IPv4 and IPv6 addresses", but in templates/etc_named.conf.j2 a temporary variable _all_addresses is created and used for the exact same purpose. This just removes the creation of the extra variable and changes the two places it's referenced to use the existing variable.

rowanthorpe avatar Sep 29 '21 20:09 rowanthorpe

Thanks for catching this! The code is becoming so complex that it's easy to miss these mistakes...

bertvv avatar Oct 09 '21 19:10 bertvv