tableau-scraping icon indicating copy to clipboard operation
tableau-scraping copied to clipboard

README example does not work anymore.

Open rasjani opened this issue 1 year ago • 4 comments

Example starting at: https://github.com/bertrandmartel/tableau-scraping/blob/master/README.md?plain=1#L30 does not work anymore.

Code is looking for textarea tag with an id but it looks like there's no such tag in the page anymore. Tableau change thats not reflected in the scraper side ?

Few people on StackOverflow has question about this:

  • https://stackoverflow.com/questions/78034286/python-tableauscraper-issue
  • https://stackoverflow.com/questions/73407859/tableauscraper-library-is-not-detecting-worksheets

Im not tableau-scraping user. I just filed this issue so that people are aware that current implementation most likely does not work.

rasjani avatar Feb 21 '24 14:02 rasjani

I'm getting the same error, JSONDecodeError: Expecting value: line 1 column 1 (char 0)

JeremyWhittaker avatar Mar 04 '24 18:03 JeremyWhittaker

I think I might have a fix that solves the problem in #79. or at least it fixes it for my case

djay avatar Mar 12 '24 04:03 djay

Your fix works great for the example in the README, @djay. I've tried it with another URL and I get the correct list of files but with empty dataframes.

PierreMesure avatar Mar 27 '24 12:03 PierreMesure

@PierreMesure It worked for my usecase. Someone else might have to extend the patch to make it work for that other example or more generally. The tests pass so there needs to be more tests. Someone else can build on top of my patch to work out what else has changed and make it work.

djay avatar Apr 01 '24 02:04 djay