speed-test-lib icon indicating copy to clipboard operation
speed-test-lib copied to clipboard

More parameters to startDownload methods

Open sajid-verveba opened this issue 6 years ago • 3 comments

Hi, Following changes done in code base SpeedTestConstant.java FTP_DEFAULT_USER, FTP_DEFAULT_PASSWORD - remove final keyword user name can set from methods.

SpeedTestSocket.java new method startDownload with more parameters like username, password, ftp time, interval time etc

ISpeedTestSocket,java method declaration..

sajid-verveba avatar May 11 '18 09:05 sajid-verveba

why this pull request failing ???

sajid-verveba avatar May 11 '18 09:05 sajid-verveba

At this time, you can put username/password in uri like speedTestSocket.startDownload("ftp://username:[email protected]/test1Mb.db");, this way you don't have to guess all the method signatures (especially if you will add more parameter later and set default arguments for some of those).

bertrandmartel avatar May 11 '18 13:05 bertrandmartel