Results 32 comments of Bert Maher

Supposedly it works to build on Windows; we’ve received PRs to make Glow build with MSVC. But none of the “core” team uses Windows (or even has Windows boxes readily...

There's actually a way to do this, by invoking `redex-all`. `redex` is just a python wrapper that does the grunt work of unpacking the APK and passing through the appropriate...

Any suggestions for refactoring? It is really, really convenient to have `g_redex` be a global, or else it would have to be passed around everywhere. It's also nice to have...

That sounds fine; we’ve got an internal patch stack for changes like this so we aren’t blocked, I just expected it might be useful upstream too 🙂

We should really lower the logging level of those messages to INFO. As @drisspg says, it's just saying that it's using the eager kernel, but it prints out all the...

And yes, I want to move this (and maybe other transforms) after AOTAutograd for that reason. I'll take a swing at it next week.

@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D44166740).

@bertmaher has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D44168337).

This looks super useful to me, thank you for doing it! A very minor suggestion (🚲🏠) is to use + for increasing the log level instead of >. I can't...