CSSCompare icon indicating copy to clipboard operation
CSSCompare copied to clipboard

Output styles don't end with semi-colon

Open dougahall opened this issue 7 years ago • 4 comments

Here's an example output:

h2{
    padding-top: 10px
    background: blue 
}

There should be a semi-colon delimiter between the styles (and optionally after the last style):

h2{
    padding-top: 10px;
    background: blue 
}

dougahall avatar Jul 13 '17 14:07 dougahall

Hi @bertjohnson, This project was a great time-saver and we appreciate your work! We just ran into these two issues that I've submitted. I have fixes for both if you are open to pull requests.

Thanks, Doug

dougahall avatar Jul 13 '17 14:07 dougahall

The semicolon is a delimiter, not a terminator. So having no semicolon on the last statement is valid CSS.

joyously avatar Jul 13 '17 16:07 joyously

Ah, good point @joyously. The delimiter is not being placed into the output either. I've updated the example in the issue. Thanks!

dougahall avatar Jul 13 '17 17:07 dougahall

Why not add options for either @joyously?

crutchcorn avatar Jul 13 '17 17:07 crutchcorn