BandInMuseScore icon indicating copy to clipboard operation
BandInMuseScore copied to clipboard

usual chords not recognized

Open dompaon opened this issue 3 years ago • 3 comments

Hi Berteh first thanks for such a good job. some very common chords typo in Musescore are not recognized by Bandinmusscore or MMA. A-7 is often seen for Am7. A° is often seen for Adim I think it would be a great idea to have a param file for Bandinmusscore with user preferences mapping to MMA recognized chords.

dompaon avatar Oct 27 '21 13:10 dompaon

quite like the idea, thanks. Wanna give it a try ?

berteh avatar Oct 28 '21 23:10 berteh

Hi Berteh what do you mean by "give it a try" ? if you mean try to do the changein code, Im afraid it will last until I get trained in QML (and generally to modern ways of coding). Can you tell me in which code statement you get the chord from MS and write it in the MMA file ? best regards Dom

dompaon avatar Oct 29 '21 07:10 dompaon

Hi Dom, sure:

The chord (actually Harmony.text) is read from MS at https://github.com/berteh/BandInMuseScore/blob/master/BandInMuseScore3.qml#L125

It is then written into a buffer at https://github.com/berteh/BandInMuseScore/blob/master/BandInMuseScore3.qml#L97 (where improvement should allow for chords to stand on other beats that first, still)

and this buffer accumulates a whole measure, util a barline is reached https://github.com/berteh/BandInMuseScore/blob/master/BandInMuseScore3.qml#L130

and then is written to MMA file at https://github.com/berteh/BandInMuseScore/blob/master/BandInMuseScore3.qml#L227

hope this helps.

berteh avatar Nov 21 '21 12:11 berteh