Bert De Block
Bert De Block
👋 I don't think there's any documentation around that deprecation atm. It's also coming from the VM: https://github.com/glimmerjs/glimmer-vm/blob/9c44e6835d27fcc7dc0e276cf3b0ee011d1ffb90/packages/%40glimmer/runtime/lib/helpers/hash.ts#L15-L21 It basically says to not set or modify any properties directly on...
It could be that the deprecation is triggered by addon code. Normally the stack trace should indicate the offending code.
You could try searching for `targetRoute` in your `vendor.js` file to see where it's used/set and look at the surrounding code to determine from which package it originates?
I made https://github.com/emberjs/rfcs/issues/803 as a first step for this. Feedback appreciated!
Indeed, this is not possible at the moment. [Godfrey's emberconf talk](https://youtu.be/RD8a2SrjieM?t=4916) covers some scenarios which you can / can't do, including the scenario you are describing. Hope it helps!
There's also some discussion going on [here](https://github.com/emberjs/rfcs/issues/735).
@kirtan-desai My initial idea was that this line could be related: https://github.com/emberjs/ember.js/pull/19962/files#diff-e1d24ae1c27f7810153391ad26d343a5e940afd53cceff9fe1d87046ade6730dR15 Not sure though, haven't looked into it any further, but the PR linked in this issue's description is...
We've landed https://github.com/ember-cli/ember-cli/pull/10142. Thanks for everyone involved and sorry for the delay on this.
We can now use the built-in `unique-id` helper for this.
Striked through `ember-cli-sri`, `ember-cli` and `broccoli-asset-rev` as well.