puppeteer-extra icon indicating copy to clipboard operation
puppeteer-extra copied to clipboard

Failing two tests on Windows

Open moltar opened this issue 4 years ago • 3 comments

As I am working on the GitHub Actions Workflow (#245), I stumbled upon two test failures:

puppeteer-extra-plugin-stealth:   Unhandled rejection in evasions\webgl.vendor\index.test.js
puppeteer-extra-plugin-stealth:   D:\a\puppeteer-extra\puppeteer-extra\node_modules\puppeteer\lib\Page.js:213
puppeteer-extra-plugin-stealth:   Error: Page crashed!
puppeteer-extra-plugin-stealth:   Page._onTargetCrashed (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Page.js:213:24)
puppeteer-extra-plugin-stealth:   CDPSession.Page.client.on.event (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Page.js:122:56)
puppeteer-extra-plugin-stealth:   CDPSession._onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Connection.js:200:12)
puppeteer-extra-plugin-stealth:   Connection._onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Connection.js:112:17)
puppeteer-extra-plugin-stealth:   WebSocketTransport._ws.addEventListener.event (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
puppeteer-extra-plugin-stealth:   WebSocket.onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/ws/lib/event-target.js:120:16)
puppeteer-extra-plugin-stealth:   Receiver.receiverOnMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/ws/lib/websocket.js:789:20)

puppeteer-extra-plugin-stealth:   Unhandled rejection in evasions\navigator.plugins\index.test.js
puppeteer-extra-plugin-stealth:   D:\a\puppeteer-extra\puppeteer-extra\node_modules\puppeteer\lib\Page.js:213
puppeteer-extra-plugin-stealth:   Error: Page crashed!
puppeteer-extra-plugin-stealth:   Page._onTargetCrashed (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Page.js:213:24)
puppeteer-extra-plugin-stealth:   CDPSession.Page.client.on.event (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Page.js:122:56)
puppeteer-extra-plugin-stealth:   CDPSession._onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Connection.js:200:12)
puppeteer-extra-plugin-stealth:   Connection._onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/Connection.js:112:17)
puppeteer-extra-plugin-stealth:   WebSocketTransport._ws.addEventListener.event (D:/a/puppeteer-extra/puppeteer-extra/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
puppeteer-extra-plugin-stealth:   WebSocket.onMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/ws/lib/event-target.js:120:16)
puppeteer-extra-plugin-stealth:   Receiver.receiverOnMessage (D:/a/puppeteer-extra/puppeteer-extra/node_modules/ws/lib/websocket.js:789:20)

Any clues on how to fix these two are appreciated.

If I can't get any help, I'll try it in a local VM.

moltar avatar Jul 10 '20 04:07 moltar

Page crashed sounds ugly and indicates more of an underlying setup issue than bad tests.

Might be that the windows box/vm ran out of RAM or has a non-optimal config? e.g. https://github.com/puppeteer/puppeteer/issues/1321#issuecomment-378361236

berstend avatar Jul 10 '20 04:07 berstend

I don't think they are running Windows in Docker though?

I'll look into it later. We can comment out Windows tests for now, if we want to merge the PR faster.

moltar avatar Jul 10 '20 04:07 moltar

I don't think they are running Windows in Docker though?

No idea, haven't looked at it (though they must use some virtualization for their windows boxes).

I'll look into it later. We can comment out Windows tests for now, if we want to merge the PR faster.

Sounds good, Windows (testing) support is definitely a nice to have :-)

berstend avatar Jul 10 '20 04:07 berstend