geckolib icon indicating copy to clipboard operation
geckolib copied to clipboard

Shader Armor Reflections incompatible

Open wisefries opened this issue 1 year ago • 12 comments

When using Iris shaders supporting labPBR resource packs, armor reflections are not present.

Active mods:

  • GeckoLib 4.2.4
  • Iris
  • QFAPI
  • Sodium

To replicate, use any shader with labPBR resource pack support, e.g. Complementary Reimagined, and a resource pack with PBR formatted textures, e.g. DefaultPBR. (Modrinth links)

Intended effect, with Iris and Sodium: Iris When GeckoLib is present: Gecko

wisefries avatar Feb 20 '24 22:02 wisefries

Update the mod then?

Tslat avatar Feb 21 '24 04:02 Tslat

my mistake, I mistyped 4.2.4 instead of the current version, 4.4.2. It's just a minor incompatibility that I thought I should mention.

wisefries avatar Feb 21 '24 15:02 wisefries

I'm having the same issue with the same mods. Both POM and reflections (from resource packs using labPBR) on all movable entities (e.g. boats, minecarts, etc.) do not render.

pnk2u avatar Mar 21 '24 14:03 pnk2u

If you disable geckolib's mixins by removing the mixins from the mixins.json in the jar, does it fix it?

Tslat avatar Mar 21 '24 18:03 Tslat

Yes, doing that fixes it. The POM and reflections render normally.

pnk2u avatar Mar 22 '24 02:03 pnk2u

I see

Tslat avatar Mar 22 '24 11:03 Tslat

Can this be tested in 1.20.6+ pls

Tslat avatar May 21 '24 06:05 Tslat

Using 1.20.6 (v4.5.2): No change, same issue

pnk2u avatar May 23 '24 17:05 pnk2u

Damn

Tslat avatar May 23 '24 19:05 Tslat

I also ran into this issue. I was running Patrix textures and noticed that the squids and iron golems were no longer reflective/shine. I tested all versions of Geckolib available on Modrinth (4.2.1 to 4.4.6). None fixed the issue.

Like it was suggested earlier, I opened the geckolib.mixins.json file contained in the .jar file, removed the entries in the "client" section so it is a set of empty brackets [ ].

This fixed the issue.

For those interested you can open a .jar file by changing the .jar to .zip and then open the archive. You can then open the .json file with a text editor like notepad. save the edited .json file to your desktop, and then drop and replace the old .json in the .zip file. when done, rename the .zip file back to .jar.

If there is a better way to temp patch this mod let me know. I can also test any potential fixes here as well.

MC 1.20.1 Fabric Iris Sodium Lithium Indium Continuity Entity Model Features Entity Texture Features Vanadium (colormatic replacement)

BSL shaders Patrix texture pack

blunderbust avatar Jun 20 '24 15:06 blunderbust

Actually, and since you asked, you can only remove the "client.TextureManagerMixin" (and the comma in the line above), you don't need to remove all of them.

pnk2u avatar Jun 20 '24 17:06 pnk2u

I can't seem to replicate this on 1.21 4.5.5?

image

Tslat avatar Jun 21 '24 11:06 Tslat

Good news I've figured out what's causing this and how to fix it

Bad news Fixing it properly is quite problematic, so it'll take me some time to figure out how I want to approach it

Tslat avatar Jul 18 '24 20:07 Tslat