Bernd Ahlers

Results 163 comments of Bernd Ahlers

> @bernd what do you think? Is this a valid and usable approach? Can we merge it? Thanks! @todvora, I like the general approach! :+1: We should improve a few...

> > Our server config uses a space character around the =. I think that makes it more readable > > Easy to implement, done. > :+1: Thanks! > >...

> @bernd could you please have a look if this sections support is sufficient? Thanks! I currently don't have time for a review. The approach looks good to me, though....

What's the use case for storing the units in the database? There aren't that many units for data values. Why not just hardcode them in the UI code?

> We would like to avoid the necessity to change the code if a new unit is needed. We hope it can be just added to DB and the rest...

I doubt that we need more than this: https://github.com/grafana/grafana/blob/2d9d0e61b132b3eecc7a9c61a72235dbd19d9711/packages%2Fgrafana-data%2Fsrc%2FvalueFormats%2Fcategories.ts#L37-L439 😄

Sorry for the sluggish responses. I was at an off-site meeting. > Is it really problematic that we have a new collection? It won't be big, so I assume it...

@luk-kaminski If you continue with the database approach, please remember to implement content-pack support for units and add dependency resolution for the view entities. Otherwise, the referenced units in views...

Sorry, I don't understand the issue. :confused: What is your exact problem and with which recipe in this repository?