best_in_place
best_in_place copied to clipboard
bernat
Remove rails 6 deprecations
- Fix rails 6 deprecations
- Attempt to fix tests
- Added rails 5.1 & 6 and ruby versions 2.5.7 & 2.6.5 to tests
- Removed rails 3.2, 4.0 and 4.1
Resolves https://github.com/bernat/best_in_place/issues/623 Resolves https://github.com/bernat/best_in_place/issues/621 & https://github.com/bernat/best_in_place/issues/611
@JDrizzy awesome job. To make the tests pass for Rails 4.2 work you probably need to pin rspec-rails to 3.x. and bundler to 1.x.
By the way, I can confirm that this works with our Rails 5.2 in production. Also works after upgrading to Rails 6 in my development environment.
Does it work with web packer?
I'm currently using it on a production app with webpacker, but the library's assets are still being provided by sprockets, unfortunately.
Hi, I'm not sure how to solve the issue. What should I do to make work with rails 6? someone gave me the link to this page but what steps should I take or follow. Any tips?
Thanks,
@Amm1r-IT to use the changes for this PR you can either reference my repository in your gemfile:
gem 'best_in_place', github: 'JDrizzy/best_in_place'
Or, fork your own copy and reference that instead.
Ideally, this PR should be merged so you don't need to complete the above two workarounds but I'm not sure when that will be.
