best_in_place icon indicating copy to clipboard operation
best_in_place copied to clipboard

add multiple option for select

Open sbeam opened this issue 9 years ago • 4 comments

when option "multiple" is true, will process original value as array (joined on comma for now for display), and then pass array of selected options directly back to controller. Always adds a button because the change event is often fired spuriously when interacting with a multiselect.

(there seems to be desire for this feature (eg, #285) and it's working in production for me. Feedback welcome - PS this gem is great :+1: )

sbeam avatar Jan 21 '16 17:01 sbeam

getting an unrelated failure on "should be able to use bip_bool to change a boolean value using an image" locally on master, and now on CI as well. Not sure what is going on with that, will look into if I get a sec

sbeam avatar Jan 21 '16 18:01 sbeam

This is great, although I'm getting Uncaught TypeError: Cannot read property 'indexOf' of undefined when there is no value.

EmmaB avatar Jan 24 '16 16:01 EmmaB

@EmmaB good catch - I made a commit to deal with that, does it work better?

sbeam avatar Jan 25 '16 19:01 sbeam

@sbeam Sorry for the slow reply -- yes, that works perfectly.

EmmaB avatar Mar 05 '16 20:03 EmmaB