dungeon icon indicating copy to clipboard operation
dungeon copied to clipboard

Map legend

Open bernardosulzbach opened this issue 9 years ago • 9 comments

Add a legend. It could be on the right bottom portion and contain the 6 different location types closest to the player.

bernardosulzbach avatar Jun 20 '15 17:06 bernardosulzbach

Hi, I would like to work on this issue. For the implementation, is adding the map using function makeWorldMap(int rows, int columns, boolean limited) to the JTextPane ok?

Immutablevoid avatar Nov 13 '19 15:11 Immutablevoid

For the implementation, is adding the map using function makeWorldMap(int rows, int columns, boolean limited) to the JTextPane ok?

I will see about this later.

I think that you could output two lines less and use the two lines to show four (or six) locations, two per line, after the map lines:

G - Graveyard               C - Cave
F - Forest                  S - Savannah

Don't worry if you don't get it right the first time. PR's are there for this. Also, there are multiple ways to do this "right". Good luck, @ImmutableBox.

bernardosulzbach avatar Nov 13 '19 17:11 bernardosulzbach

Oh OK, a map legend. Sorry I was thinking mini-map for some reason. Something like this (Mock-up I made in paint):


If it's a map legend, then it's exclusively on the map command?

Something like this: image

Immutablevoid avatar Nov 13 '19 18:11 Immutablevoid

If it's a map legend, then it's exclusively on the map command?

Precisely. Just like your last image.

Note that if you remove "Legend:" it might be possible to fit a 2 by 3 legend (6 mappings of symbol to name). Don't try to fit too much though, eventually, the game might have longer location names and having a lot of things in there won't be possible.

I plan on eventually decoupling the output of the "engine" and the GUI so that we can move on to something more modern than what we are using right now (playing in a web browser could be possible, adding visual mods, etc.), so a minimap has a larger chance of being thrown away than the legend. Plus, I'd think that the legend is easier to implement than the minimap.

bernardosulzbach avatar Nov 13 '19 18:11 bernardosulzbach

Ok, Understood. Thanks for the help. :+1:

Immutablevoid avatar Nov 13 '19 18:11 Immutablevoid

By the way, can you share which Java version you are using?

I am considering bumping this project's version up, but now that Java versions became a bit of a mess I am trying to gauge what is appropriate.

bernardosulzbach avatar Nov 13 '19 20:11 bernardosulzbach

java version "1.8.0_231"

I remember I used 13.0.1 while trying to run this project before, but it didn't work. Hope that helps.

Immutablevoid avatar Nov 13 '19 20:11 Immutablevoid

I remember I used 13.0.1 while trying to run this project before, but it didn't work. Hope that helps.

I am aware. The main issue I see is that by moving it to Java 11 I will likely make it Java 11 or newer, which could be an issue for people running older Java. However, this might be a "better problem" than making it Java 8 only. Thanks for the quick reply.

bernardosulzbach avatar Nov 13 '19 20:11 bernardosulzbach

This has been partially addressed. The main aspect in which I think this is lacking is that it doesn't show only distinct locations close to the player. Some refinement is needed.

bernardosulzbach avatar Nov 16 '19 20:11 bernardosulzbach