Bernard Normier comments

Results 155 comments of


                                            Bernard Normier

Deprecate Object used as Value

Let's keep Object as an alias for Value, for compatibility with earlier versions of Slice.

Restore catch (exception_ptr)

I was hoping you had insights into this code. The generated code throws "current_exception()" only in this one spot: that's when a user-provided lambda response throws an exception. And we...

Restore catch (exception_ptr)

I was mistaken: we do throw current_exception() for regular lambdas too, in LambdaOutgoing: ``` try { response(); } catch(...) { throw std::current_exception(); } ```

Remove cpp11 references in vcxproj project files

I would just remove cpp11, i.e. put them in ``` ``` and friends. A related issue is #1699. I think the solution for Windows builds is to include the individual...

Remove cpp11 references in vcxproj project files

> A related issue is #1699. I think the solution for Windows builds is to include the individual generated directories (-Igenerated/.../Debug/Ice) when building and NOT the enclosing directory (.../Debug). Actually...

Adopt new Slice class format and preservation approach

Yes, so far we plan to keep the 1.0 encoding in 3.8. It should have no or limited effect on this issue since slice preservation is 1.1-only.

Incorrect escaping in C++ generated code

There is a similar issue with the code generated by slice2swift.

Disallow hold->activate-hold->... pattern

The proposal is: - a newly created object adapter is in the hold state (just like today) - when you call activate, it becomes active (just like today) - once...