Bernardo Ferrari

Results 346 comments of Bernardo Ferrari
trafficstars

Could you check what's failing in Google testing and if it's a big deal? Else the bigger change might trigger more things.

Hey! Sorry for the end of the year delay! 😅 Tests are ok now. So, I just did what you asked me to. I added `super.allowedButtonsFilter` everywhere. This creates a...

- What should I do with DoubleTapGestureRecognizer? It is primary button only right now. - Should we do anything with LongPressGestureRecognizer? I don't think so. I changed the default `allowedButtonsFilter`...

`DoubleTapGestureRecognizer` is going to call `super.isPointerAllowed(event)` which triggers the change we are making. By default it accept all, so no changes. But you can do weird things, because `allowedButtonsFilter` can...

> Though I do worry a bit that not adding allowedButtonsFilter to some GestureRecognizers may lead to a inconsistent experience for a developer We can add it, it will probably...

> Can you explain why the second button is ignored and the double tap recognizer `isPointerAllowed` is the first thing that is executed, so if it is not allowed, it...

Fixed with https://github.com/flutter/flutter/pull/111852/commits/708493ff66524942321eade5a2e6a7ad217c0b01 😛

That's it for now, I guess. If you want to re-review @Renzo-Olivares @moffatman or approve, feel free.

Unless you show your code, stack-trace or anything, no one will be able to guess anything.

Yeah, no problems.. I even integrated into my app (you can try here: https://github.com/bernaferrari/ChangeDetection) and no issues.