converjon icon indicating copy to clipboard operation
converjon copied to clipboard

Use mash/node-imagemagick-native instead of CLI?

Open selfawaresoup opened this issue 10 years ago • 5 comments

Instead of using CLI calls to run imagemagick, maybe use mash/node-imagemagick-native.

Avoiding CLI could greatly reduce complexity and potential errors. This needs to be evaluated.

selfawaresoup avatar Jan 29 '15 23:01 selfawaresoup

The following diskussion might be helpful: https://github.com/mash/node-imagemagick-native/issues/46

But in theory, the native client should be much faster and on bigger files, it should have the same performance like the CLI.

trendfischer avatar Jan 30 '15 08:01 trendfischer

mash/node-imagemagick-native does not support cropping parameters, yet. There is an issue for that, though: https://github.com/mash/node-imagemagick-native/issues/52

selfawaresoup avatar Mar 17 '15 10:03 selfawaresoup

Since converjon is probably mostly used to scale big source images down to thumbnails or web gallery versions, is should profit more from the performance characteristics of imagemagick (CLI).

Closing this issue for now.

selfawaresoup avatar May 12 '15 13:05 selfawaresoup

New info on this: https://github.com/mash/node-imagemagick-native/issues/46#issuecomment-55696841

selfawaresoup avatar May 12 '15 14:05 selfawaresoup

It also seems like node-imagemagick-native doesn't support cutting out specific parts of the source image. That is necessary for converjon's cropping.

selfawaresoup avatar May 18 '15 09:05 selfawaresoup