spectra-hash icon indicating copy to clipboard operation
spectra-hash copied to clipboard

Fixed histogram binning issue in splashR

Open ssmehta opened this issue 1 year ago • 0 comments

Fixes inconsistent histogram generation between the R and Java implementations reported in MassBank/MassBank-data#248.

In splashR, the epsilon correction factor was not applied before converting binned intensities to integers. Without the correction one of the bins was lost due to a floating point artifact in this particular spectrum. I'm surprised that error this did not come up in any of our test sets during validation.

ssmehta avatar Nov 14 '23 11:11 ssmehta