Håvard Berland comments

Results 150 comments of


                                            Håvard Berland

Close stdin/stdout/stderr files when done

> Looks good! (1) Do you think it would make sense to have a test for this? (2) There is a linting opportunity "Use a single if-statement instead of nested...

Close stdin/stdout/stderr files when done

jenkins test this please

Close stdin/stdout/stderr files when done

The failing test looked like Jenkins flakyness, seems ok now.

Close stdin/stdout/stderr files when done

Changing release note label to maintenance since it is not really a bug in CPython as of now.

Close stdin/stdout/stderr files when done

Oh no, forgot to squash!

Remove deprecated warnings from snake_oil

UMASK warning is covered by #3017

Remove deprecated warnings from snake_oil

Replacing `setDaemon() `is perhaps possible now that we support 3.8 only?

Remove deprecated warnings from snake_oil

Fixing the `setDaemon() `warning is actionable right now, https://docs.python.org/3.8/library/threading.html#threading.Thread.setDaemon (umask is just harder to get rid of due to the peculiar current c-code parsing the ert config file, may just...

connection handler failed error in console when MAX_RUNTIME is hit

Seen to appear when things go wrong, see also https://web.yammer.com/main/org/statoil.com/threads/eyJfdHlwZSI6IlRocmVhZCIsImlkIjoiMTg4NDk3MzEyMTg1NTQ4OCJ9

connection handler failed error in console when MAX_RUNTIME is hit

For reproducing in a `test_run`, it seems necessary to have `MAX_RUNTIME >= 3` (and only `time.sleep(1)` in `poly_eval.py`). A lower `MAX_RUNTIME` will have the jobs killed, but without `connection handler...