laravel-onesignal icon indicating copy to clipboard operation
laravel-onesignal copied to clipboard

Include segments broken - Send custom notification

Open Sml995 opened this issue 3 years ago • 2 comments

In the last release an additional check is performed before setting $parameters['included_segments'] = ['All'] by default in sendNotificationCustom()

However the check is on the string instead of the array index:

empty('include_external_user_ids')

Should be:

empty($parameters['include_external_user_ids'])

Sml995 avatar Apr 25 '22 14:04 Sml995

Any news??((

sevak88 avatar May 25 '22 11:05 sevak88

@berkayk Would be great to merge that, let us know if you need any help

Sml995 avatar May 26 '22 12:05 Sml995