select2-bootstrap4-theme icon indicating copy to clipboard operation
select2-bootstrap4-theme copied to clipboard

Published 20 hours ago • verified publisher icon berkanakyurek

Placeholder Text Not Aligned Correctly On Multiple

Open Joyrex opened this issue 6 years ago • 3 comments

The placeholder text is misaligned when using Select2 Bootstrap 4 theme in multiple (tag) mode: image Adjusting the padding-top on .select2-container--bootstrap4 .select2-selection--multiple .select2-selection__rendered from .75rem to `.50rem' aligns it correctly: image

This is using Bootstrap 4.1.1 and Select2 Bootstrap4 Theme (latest)

Joyrex avatar May 21 '18 23:05 Joyrex

@joyrex thanks! Would you mind submitting a pull request with your fix?

VictorioBerra avatar May 22 '18 00:05 VictorioBerra

I've... never done that before! I went to Pull Requests, but it appears that I would have to fork this before I could create the pull request... right?

Joyrex avatar May 22 '18 16:05 Joyrex

@Joyrex

Correct, fork the repo, clone it and make changes and test your changes. Especially with CSS make sure your fix did not just break the way other things look. IE: did your change just break the positioning of the little "x" button for tags? Did your change break single select dropdowns? Try and test everything.

When you are happy with it, commit and push your changes and GitHub will show you a "create pull request" button. Its very easy.

Some things to keep in mind:

  • Make sure you follow the existing styles, formatting and structure that is in the code base. Make it clean.

VictorioBerra avatar May 22 '18 16:05 VictorioBerra