select2-bootstrap4-theme icon indicating copy to clipboard operation
select2-bootstrap4-theme copied to clipboard

Published 20 hours ago • verified publisher icon berkanakyurek

.has-error, .has-success No Longer Valid for Bootstrap 4

Open Joyrex opened this issue 6 years ago • 4 comments

changing all instances of .has-error to .is-invalid and .has-success to .is-valid allows validation classes to properly render on Select2 elements.

Joyrex avatar May 22 '18 17:05 Joyrex

Replaced .has-error, .has-warning, and .has-success classes with HTML5 form validation via CSS’s :invalid and :valid pseudo-classes.

We should definitely fix this. PRs welcome.

VictorioBerra avatar May 22 '18 18:05 VictorioBerra

For me, It looks like jQuery DataTables is adding has-error still. Not sure if they have fixed that. maybe what we want to do here is add both to the library? A lot of JS tools still use has-error as mentioned, but maybe we should follow BS4 and drop support as well.

VictorioBerra avatar May 22 '18 19:05 VictorioBerra

Yeah, DataTables needs to update their Bootstrap 4 styling to reflect 4.1.1 - it wouldn't hurt to leave the legacy classes in there; you'd just have extra CSS.

Joyrex avatar May 22 '18 19:05 Joyrex

DataTables fixed this recently https://editor.datatables.net/download/1.7.4

VictorioBerra avatar Jul 12 '18 14:07 VictorioBerra