Roey Berman

Results 111 issues of Roey Berman

The call to create the CORS object in https://github.com/theganyo/swagger-node-runner/blob/master/fittings/cors.js#L11 passes an object that looks like: ```json { "name": "cors", "input": { "some": "params passed in default.yaml" } } ``` Changing...

This is not a PR that is supposed to get merged. It's simply a place where we can accumulate late review comments.

## What changed? Use "Eventually" for the TLS refresh test instead of fix sleep time. ## Why? The test was flaky, nobody likes those.

We recently added the ability for an activity to specify the next retry delay on failure via a [field on `ApplicationFailureInfo`](https://github.com/temporalio/api/blob/822966d29758cba3462d6f5ff198257fbaa426f6/temporal/api/failure/v1/message.proto#L49). Expose this in the SDK.

See parent issue for reference.

enhancement

This was never implemented and left as a TODO in the code: https://github.com/temporalio/sdk-core/blob/a56b28d590fcaf518d813c41267ddd913a18d059/core/src/worker/activities.rs#L645

bug

Part of the design for the `patched` and `deprecatePatch` APIs included a method for users to verify when old code branches can be removed and when deprecated patches can be...

enhancement

This error is seen on rare occasions in both the TypeScript and Python SDKs: TypeScript: ``` IllegalStateError: Received workflow activation for an untracked workflow with no start workflow job ```...

bug

Since our goal with metrics is to expose a generic interface for metrics recording in our lang SDKs using industry standards, we should expand the metrics API in core to...

enhancement

Currently Core relies on the server to detect when an activity times out, requiring activity implementations to heartbeat in order to get cancelled. Core should copy the behavior from the...

enhancement