Christoph Bergmeister

Results 271 comments of Christoph Bergmeister

Asking on a per file basis was the easiest to implement because otherwise there are many different low level code paths for invoking rules as they are treated differently internally...

Good idea, I wonder if this can be part of the command log in general because in theory it should be possible to annotate whether a suppression entry caused a...

Currently it checks whether the variable name contains one of those words, one of which is cred https://github.com/PowerShell/PSScriptAnalyzer/blob/f77acdf4cfed22b4b5bd106ac07951991ce824b7/Rules/AvoidUsingPlainTextForPassword.cs#L34 The logic could be tweak to specifically exclude `credit` or be more...

This is marked as an improvement but there will always be false positives, which is what the suppression feature is catering for. I suggest you check this out and do...

We would need to either abuse an existing property in `DiagnosticRecord` or create a new property or optional constructor parameter (which would require a new version of PSSA), I think...

Awesome, go for it. Please note that at the moment, only the Windows build images work (a PR is open to fix the Ubuntu build), therefore it is normal that...

Cc @rkeithhill Just FYI as we'll need also a PRs in PSES and the vscode extension

This 'working solution' is a really bad hack and I strongly recommend against using it. The `ms-vscode.powershell` has been a bit quiet in the last months with releases but generally...

Yes, you'd add a property to `DiagnosticRecord` and then translate that property similar to how it was done in that referenced PR.

@Shruti-MS No, but you could follow the above guidance and we'd be happy to accept a PR