Adam Bergmark

Use auto-formatting (hindent?)

14

I think auto-formatting is a big win. hindent also formats very close to what I do personally anyway so I'm a big fan, but there are a lot of differences...

Mismatch between derived To/FromJSONKey and To/FromJSON instances for "strings"

2

I think this was an oversight and we need generics for To/FromJSONKey to make those instances match To/FromJSON. The reason this happens is that deriving ToJSON for some types such...

httpbin test failures

2

Moving https://github.com/commercialhaskell/stackage/issues/5470 here as we've disabled the test suite on stackage. Original: ``` Test suite failure for package http-client-0.6.4.1 spec: exited with: ExitFailure 1 Full log available at /var/stackage/work/unpack-dir/.stack-work/logs/http-client-0.6.4.1-test.log Network.HTTP.Client...

servant-client doesn't return envelopes for non-2xx status codes

4

Full reproduction: https://github.com/bergmark/sce Using servant-0.13.1 and servant-checked-exceptions-2.0.0.0 ```haskell data BadReq = BadReq deriving Show deriveJSON defaultOptions ''BadReq instance ErrStatus BadReq where toErrStatus BadReq = badRequest400 type API = Throws BadReq...

I found this counterintuitive: ``` #[test] fn backoff() { let x: Vec = tokio_retry::strategy::ExponentialBackoff::from_millis(50).take(5).collect(); dbg!(x); } x = [ 50ms, 2.5s, 125s, 6250s, 312500s, ] ``` Looking at the source...

``` src/Data/Integer/SAT.hs:1:14: Unsupported extension: Trustworthy ``` I've revised existing versions so a new release isn't necessary.

test suite and benchmark compilation failures

1

The test-suite for this package has been disabled in stackage because of this issue. If a fix is published to hackage can you please ping me? Thanks! ``` > /tmp/stackage-build8/thyme-0.3.5.5$...

``` > /tmp/stackage-build8/doctest-0.11.0$ dist/build/doctests/doctests src/GhcUtil.hs:13:1: error: Ambiguous interface for ‘Panic’: it was found in multiple packages: protolude-0.1.6 ghc-8.0.1 ``` I'm adding this test suite as an expected failure in stackage....

test suite & benchmark failures

2

I think we forgot to re-enable the test suite for stackage, but now there are new failures: ``` > /tmp/stackage-build8/xmlgen-0.6.2.1$ runghc -clear-package-db -global-package-db -package-db=/var/stackage/work/builds/nightly/pkgdb Setup configure --enable-tests --package-db=clear --package-db=global --package-db=/var/stackage/work/builds/nightly/pkgdb...

`emptyUpdate` got new semantics with opaleye-0.4

5

To fix this I think we should scrap `runUpdateConst` and replace `emptyUpdate` with another TH-generated function `IdUpdate :: To Column R -> To Maybe (To Column R)` which could be...