create icon indicating copy to clipboard operation
create copied to clipboard

change is not implemented

Open uwej711 opened this issue 11 years ago • 10 comments

Not sure but this looks like a backbone change ...

uwej711 avatar Dec 18 '13 15:12 uwej711

@bergie looks like the travis setup with saucelabs is broken... could you investigate?

dbu avatar Apr 17 '14 14:04 dbu

@dbu travis setup is fixed now

bergie avatar Jan 19 '15 14:01 bergie

@bergie great. can you click on the failed build link and restart the build so we can see if this works? and review the PR and merge if its good?

dbu avatar Jan 21 '15 08:01 dbu

@dbu did you rebase? The build fixes are only in master

bergie avatar Jan 21 '15 11:01 bergie

Rebased

uwej711 avatar Jan 21 '15 12:01 uwej711

strange. this still stops at a build error, but travis says that the master is building correctly. @uwej711 can you re-check if you have everything from upstream master?

dbu avatar Jan 21 '15 13:01 dbu

Checked, the only difference I see doing git diff origin/master uwej711/change is the same as here ...

uwej711 avatar Jan 21 '15 14:01 uwej711

@bergie any idea what is causing the problem on travis then?

dbu avatar Jan 21 '15 14:01 dbu

@dbu @uwej711 well, the latest fails with Bower trying to install rangy: https://travis-ci.org/bergie/create#L231

Checking that, it seems this is now replaced by rangy-official

bergie avatar Jan 21 '15 14:01 bergie

@dbu @uwej711 builds are passing now on master again, please rebase

bergie avatar Jan 22 '15 15:01 bergie