Light-Cleaner icon indicating copy to clipboard operation
Light-Cleaner copied to clipboard

[BUG] /cleanlight world spams cosole with errors

Open Tsoccerguy3 opened this issue 3 years ago • 6 comments

Bumps follow-redirects from 1.14.9 to 1.15.6.

Commits
  • 35a517c Release version 1.15.6 of the npm package.
  • c4f847f Drop Proxy-Authorization across hosts.
  • 8526b4a Use GitHub for disclosure.
  • b1677ce Release version 1.15.5 of the npm package.
  • d8914f7 Preserve fragment in responseUrl.
  • 6585820 Release version 1.15.4 of the npm package.
  • 7a6567e Disallow bracketed hostnames.
  • 05629af Prefer native URL instead of deprecated url.parse.
  • 1cba8e8 Prefer native URL instead of legacy url.resolve.
  • 72bc2a4 Simplify _processResponse error handling.
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Tsoccerguy3 avatar Dec 22 '21 06:12 Tsoccerguy3

Made some changes, see if it helps any at eliminating the 10s+ long tick durations.

https://ci.mg-dev.eu/job/BKCommonLib/1184/ https://ci.mg-dev.eu/job/Light-Cleaner/127/

bergerkiller avatar Dec 22 '21 14:12 bergerkiller

The console spam is gone .Here is timing report https://timings.aikar.co/?id=d7b449d2c64341fbb8e1e34bc7381304#plugins .

Tsoccerguy3 avatar Dec 22 '21 14:12 Tsoccerguy3

its unlikely to get better than that - there is no safe way to read block data in an asynchronous fashion. Not safely anyway...

bergerkiller avatar Dec 22 '21 14:12 bergerkiller

Do you have any recommendations to further optimize the server while running /cleanlight world .

Not sure why but all the worlds that I migrated over to 1.18.1 , all work well. The light on all the worlds are set at its highest brightness , no dark areas and no shadows . My guess is that the light in each block needs a reset. Likely just need to run /cleanlight world just once on each map

Tsoccerguy3 avatar Dec 22 '21 14:12 Tsoccerguy3

The world command is kind of extreme and I generally don't recommend people use it on a live server, let alone more than once. So yeah, run it once, and if new bugs ever show up do a local fixup there.

Do note that a worldwide clean can result in new chunks being generated at the very edges of the world, so if that was carefully trimmed before, thatll have to be done again.

bergerkiller avatar Dec 22 '21 14:12 bergerkiller

WorldBorder has the /wb trim command , that i will run after I'm done . I will find out if this also has the effect of generating content below y=0 . This will also speed up the server if the worldgen is not constantly running. Thanks . I will keep you posted

Tsoccerguy3 avatar Dec 22 '21 14:12 Tsoccerguy3