Light-Cleaner icon indicating copy to clipboard operation
Light-Cleaner copied to clipboard

Paper 1.12.2 crash and hangs

Open jiongjionger opened this issue 4 years ago • 6 comments

crash log: https://paste.ubuntu.com/p/zYd7cdRqQ8/ server version: paper 1.12.2 latest bkcommonlib version: 1.16.4-v2 lightcleaner version: 1.16.4-v1

jiongjionger avatar Dec 07 '20 12:12 jiongjionger

Please, do everyone a favour and use https://paste.traincats.net to share errors. Also, prove additional info such as servrr version, bkcommonlib version and lightcleaner version.

Andre601 avatar Dec 07 '20 12:12 Andre601

Is auto cleaning enabled? Is it related to that or did you do a worldwide clean of sorts using commands?

bergerkiller avatar Dec 07 '20 17:12 bergerkiller

autoCleanEnabled: false autoCleanWorldEditEnabled: true

There is a probability that this problem will occur when I use FAWE or use API calls LightingAutoClean.schedule(world, chunkX, chunkZ, 20).

jiongjionger avatar Dec 07 '20 19:12 jiongjionger

I think I know what this is. Give me a moment

bergerkiller avatar Dec 07 '20 19:12 bergerkiller

The core issue is that in light cleaner it performs some logic in parallel, and some code in bkcommonlib wasn't written with parallel (multithread) in mind. Give this a try to see if problems go away, if they don't, I might need to get rid of parallel() in light cleaner and read chunk data one 16x16x16 area of blocks at a time instead.

https://ci.mg-dev.eu/job/BKCommonLib/968/

bergerkiller avatar Dec 07 '20 19:12 bergerkiller

Thank you very much. I'll try it later.

jiongjionger avatar Dec 08 '20 11:12 jiongjionger