Fix/spelling and loglevels
This PR tightens up the language and grammar in new warning messages
It also demotes a number of log messages from Info to Debug; I chose ones that don't mention a block#, only a block hash or other details.
There are still a good number of log messages sent at loglevel INFO for every block. RFC on idea of demoting them all to Debug or promoting one of them to Warning so in the ordinary course of events, one line per block goes out, but importantly, if additional proposal rounds go around these should be warnings.
- Timed out
- Received proposal
- Received complete proposal
- processExecutionPayload
- Finalizing commit of block
- processExecutionPayload again
- Finalized block
- Committed state
I don't understand why a bunch of other people's commits got roped into this. I made this branch and its commits in the past 5 hours
Codecov Report
:x: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 60.94%. Comparing base (68ecce6) to head (25489dc).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2633 +/- ##
=======================================
Coverage 60.94% 60.94%
=======================================
Files 358 358
Lines 16864 16864
=======================================
Hits 10278 10278
Misses 5791 5791
Partials 795 795
| Files with missing lines | Coverage Δ | |
|---|---|---|
| beacon/blockchain/process_proposal.go | 68.22% <100.00%> (ø) |
|
| execution/engine/metrics.go | 39.02% <100.00%> (ø) |
|
| ...ate-transition/core/state_processor_withdrawals.go | 63.15% <100.00%> (ø) |
|
| consensus/cometbft/service/configs.go | 59.82% <0.00%> (ø) |
|
| consensus/cometbft/service/options.go | 65.51% <0.00%> (ø) |
|
| execution/client/client.go | 72.30% <0.00%> (ø) |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
to fill up my proposal, i'll add a change that demotes several other log entries to DEBUG except for 'committed'