beacon-kit icon indicating copy to clipboard operation
beacon-kit copied to clipboard
verified publisher icon berachain

Add consensuswarn to CI pipeline

Open crStiv opened this issue 11 months ago • 2 comments

Closes #833

Changes:

  • Added consensuswarn to CI matrix
  • Created consensuswarn target in Makefile
  • Integrated consensuswarn into the linter suite

The tool will run as part of the standard CI checks to help maintain code quality and prevent consensus-related bugs early in development.

crStiv avatar Feb 03 '25 00:02 crStiv

https://github.com/orijtech/consensuswarn Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

rezbera avatar Feb 03 '25 14:02 rezbera

https://github.com/orijtech/consensuswarn Repo hasn't been updated in 6 months. Don't think we want to be adding unused and unmaintained tools. wdyt @abi87

This is related to https://github.com/berachain/beacon-kit/issues/833 which is marked goodFirstIssue so it's a fair attempt at contributing. I like the idea of the tool, but it's probably an overkill for us? We should discuss this. Definitely this PR does not do all the job though: I believe we have to mark the proper functions to be warned about

abi87 avatar Feb 03 '25 14:02 abi87