bepro-js icon indicating copy to clipboard operation
bepro-js copied to clipboard

Published 20 hours ago • verified publisher icon bepronetwork

Feature/preadd lint

Open nodexchange opened this issue 3 years ago • 12 comments

Bounty

Describe the solution

Preview

ETH Wallet

Twitter Handle

nodexchange avatar May 23 '21 20:05 nodexchange

Hey @nodexchange,

Thanks for the help here :)

A few questions :

  1. By adding the build in .gitignore how did you ensure the system automatically build when people use it under the npm package?
  2. In which command does the system automatically run the eslint:fix?

Ruiub3i avatar May 24 '21 11:05 Ruiub3i

Hey,

Sorry for the late one.

  1. I would suggest moving build and publish action to github actions (I can help with it). Keeping the build folder in our source code will cause quite a few conflicts. Link for ref: https://docs.github.com/en/actions/guides/publishing-nodejs-packages.
  2. It is the .husky/pre-commit file, it triggers npm run pre-commit task which works with the lint-staged task (much faster than our previous implementation'. I've also added .husky/pre-push to run npm test meaning, nothing will be pushed without passing tests, even if it is to forks.

Happy to adjust @Ruiub3i (for tag) :-)

nodexchange avatar May 24 '21 19:05 nodexchange

Great, yes please do 1) so that we keep the build outside of the repo itself and just autobuilds in github actions

Also please resolve the conflicts, once done let me know :)

Ruiub3i avatar May 25 '21 10:05 Ruiub3i

merged in master, resolved conflicts and updated the eslint to include a few extra folders that can be ignored for now. All yours @Ruiub3i :-)

nodexchange avatar May 25 '21 20:05 nodexchange

@nodexchange does this substitute the previous pre-commit solution of [lint:fix, build, jsdoc:build]?

Ruiub3i avatar May 26 '21 20:05 Ruiub3i

@nodexchange does this substitute the previous pre-commit solution of [lint:fix, build, jsdoc:build]?

hey, yeah, it does. Instead of pre-commit, now we have a full flexibility on all different git hooks, like commit, prepush, post-push etc.

nodexchange avatar May 27 '21 12:05 nodexchange

Great @nodexchange can you pls resolve the conflicts so that I can merge?

Thanks!

Ruiub3i avatar May 27 '21 12:05 Ruiub3i

Great @nodexchange can you pls resolve the conflicts so that I can merge?

Thanks!

all done! Should be resolved and ready to merge!

nodexchange avatar May 27 '21 13:05 nodexchange

Thanks @nodexchange, now only left is the build/ files, since now we ignore all build files - so just need to remove any build/ ** - the rest looks ok :)

Great job!

Ruiub3i avatar May 27 '21 22:05 Ruiub3i

@nodexchange let me know once that is done so that I can merge, all the rest looks great!

Ruiub3i avatar May 28 '21 16:05 Ruiub3i

@nodexchange let me know once that is done so that I can merge, all the rest looks great!

sorry, missed it. On it right now.

nodexchange avatar Jun 02 '21 20:06 nodexchange

@Ruiub3i , all good to merge. I was tripped by node upgrade to 14!!! Well done team!!!

nodexchange avatar Jun 02 '21 20:06 nodexchange