bepro-js icon indicating copy to clipboard operation
bepro-js copied to clipboard

Change createNetwork to emit CreatedNetwork event

Open bepro-bot opened this issue 3 years ago • 4 comments

Change createNetwork function on the smart-contract of NetworkFactory.sol to emit the CreatedNetwork event

Change the CreatedNetwork event to emit the creators address instead of amount

bepro-bot avatar Dec 13 '21 11:12 bepro-bot

Working on this. Just need to sort out:

  • Which ID should be referenced by the CreatedNetwork event? I can't find an obvious ID (public variable) from the Network class.
  • I understand msg.sender would be the creator's address. Which address would reference the opener?

jaymeschroeder avatar Dec 14 '21 23:12 jaymeschroeder

@jaymeschroeder I would say its id is essentially its index on the networks mapping

moshmage avatar Dec 15 '21 10:12 moshmage

@jaymeschroeder is working on this.

bepro-bot avatar Dec 15 '21 15:12 bepro-bot

@moshmage, @jaymeschroeder has a solution - check your bounty

bepro-bot avatar Dec 15 '21 15:12 bepro-bot