bepasty-server icon indicating copy to clipboard operation
bepasty-server copied to clipboard

upgrade fontawesome

Open Zhangby1998 opened this issue 1 year ago • 3 comments

Font-Awesome (FortAwesome/Font-Awesome) after v5 (circa 2018) uses "fontawesome.min.css" as filename, not "font-awesome", as written in _layout.html, L18, which cause permission icon unable to show up properly. L6J6Y4PECRMZU}XRQ816A

Zhangby1998 avatar Jun 11 '23 00:06 Zhangby1998

Thanks for the hint. Seems like this worked until Dec 2022, as there was only fontawesome v4 as xstatic package, which then got updated to v6.

So we can either limit to the older fontawesome (which is likely to fix all issues, but a bit backwards and not future-proof): https://github.com/bepasty/bepasty-server/blob/master/setup.cfg#L42

Maybe this approach would be good for a minor patch release.

Or we can upgrade bepasty to v5 and then to v6, which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that - maybe more changes than the one noted in top post are needed?

This approach is what we need for future releases.

ThomasWaldmann avatar Jun 11 '23 10:06 ThomasWaldmann

Release 1.2.0 will include the workaround by requiring the old xstatic-font-awesome pypi package.

ThomasWaldmann avatar Aug 28 '23 14:08 ThomasWaldmann

TODO: Upgrade bepasty to use xstatic-font-awesome 5.x (and later to 6.x), which needs a review of fontawesome change log and upgrade notes and then a global review of our usage according to that.

ThomasWaldmann avatar Aug 28 '23 15:08 ThomasWaldmann