Bjørn Erik Pedersen

Results 871 comments of Bjørn Erik Pedersen

@jmooring while I agree about the `index` func, I also think this should be fixed where it fails in this case: https://github.com/gohugoio/hugo/blob/0071b47b8be7fed03786182f797ca1cef5185f54/common/hreflect/helpers.go#L104 I also question why `Heading` implements `IsZero` if...

>Is there an option to make it write its dependencies to, say, hugo.mod instead of the go.mod file? Not that I know of, but I would be happy to be...

OK , thinking a little I think I know what we can do. I have implemented my own "tidy logic" because Go does not understand Hugo's imports. We can adjust...

>Shame Hugo can't use a different file. Or Mage. ![image](https://user-images.githubusercontent.com/394382/61962298-7e136b80-afc9-11e9-9b98-1f2eb93184e1.png) I have double-checked the Go source, and `go.mod` is very much hardcoded ... all over the place. I will take...

>i.e. the dependencies need to be declared in Go code if go mod tidy is to see them. Which is exactly what Hugo does (if you replace "Go code" with...

I have "turned off" the tidy during regular builds. WIll be in Hugo 0.57.1. You will still see this problem if you do `hugo mod tidy`.

>Just wanted to make sure we're talking about the same thing here: for go mod tidy to work, the dependencies will need to be declared in Go code. We're obviously...

> I had understood from the conversation above that the Hugo module dependencies would be added to go.mod, but I guess that is not the case. They do, but the...

>After all, the go.mod file belongs to go mod, not Hugo. Just to make my point clear: * `go mod tidy` acts as if it owns `go.mod`, which is probably...