Bjørn Erik Pedersen

Results 451 comments of Bjørn Erik Pedersen

Note that I would really appreciate if the scope of Goat could be as simple and narrow it is now (ascii => svg). I understand the need for the cmd...

>The config files are loaded via viper. I see viper has a SetFS function, only, it doesn't accept os.FS (which embed.FS implements). I notice there are two-way-adapters for `os.Fs`, couldn't...

>I'm guessing that if you tried to use viper.SafeWriteConfigAs or otherwise tried to write to a FromIOFS-wrapped embed.Fs, you'd get an error. It's a long time since I looked at...

Sorry for being very late to the game, this looks very useful. I have read the discussion above, but I suspect that we're missing out on some potential when we...

Yes. Not sure why it is a pointer, but that is another debate.

I saw a discussion on gopher-nuts about this, and I believe one of the Go core devs argued that functions/methods should take interfaces as arguments when possible, but return concrete...

@moorereason to get some effect out of what you're saying, you need to un-export the concrete types, which would be painful in the wild. My main argument for returning the...

> I only mean that BasePathFs.RealPath should be unexported. Sure, but that is a topic for another thread. The "effective Go" link you provide seems to be old. I have...

An added note to the above: I have a long background with Java, and I kind of hate when people talk about `idomatic Go` -- but when it comes to...

I think you need to start with why this is needed? Looks like a breaking change.