Björn Rabenstein
Björn Rabenstein
@jesusvazquez @codesome it was decided one of you should review this. :grin:
@jesusvazquez @codesome it was decided one of you should review this. :grin:
As per direct communication, @fpetkovski will work on this.
OK, I'll close this then. More optimizations can always be done, even if no issue prompts for it. :smile:
@haoranleo do you plan to work in this yourself? I think this would be a very welcome feature, but @roidelapluie has more context for sure.
With SigV4 supported by remote write, maybe we have already linked in most of the required dependencies?
Inclusion/exclusion via build tags would be nice, I guess. (It could also be opt-out, so that users that care about binary size can exclude it, similar to what we do...
I think @roidelapluie is talking about having all the library dependencies linked into the binary, even for those users that don't need SigV4 support.
I think we want to remove the feature flag entirely and have no way to bring the old behavior back. But @roidelapluie has more context and should confirm.
Sorry for confusion. An almost similar PR was created recently, see #14958, and some discussion happened over there. The discussion over there is relevant, but the changes should happen in...