Björn Rabenstein

Results 1096 comments of Björn Rabenstein

This is a hysteresis style alert. We discussed it at the dev summit, see [meeting notes](https://docs.google.com/document/d/11LC3wJcVk00l8w5P3oLQ-m3Y37iom6INAMEu2ZAGIIE/edit?pli=1#heading=h.ro1r0q736gqw) (search for "hysteresis" to find the relevant section). tl;dr: We like it, and I...

I believe my proposal in the doc is able to satisfy all the proposed use cases: > Model it that way: Every alert now has two queries and two “for”s,...

To illustrate the differences between the "multi expression approach" I have suggested above and the "keep-firing-for approach" implemented by #11827, I have created a little drawing: ![PXL_20230117_135951901](https://user-images.githubusercontent.com/5609886/212919646-8ba76e22-a447-4327-85ce-875213fb5464.jpg) Box I shows...

> In my opinion, the weak points of the proposed implementation are the following: I don't think these points are very relevant. > * Using two queries increases the load...

With my proposal, you have to understand (and debug) two expressions, both written in PromQL. With your proposal, you have to understand (and debug) three expressions written in two different...

The original sin here is that we (ab-)use label values (which are strings) as numbers (in this case bucket boundaries). The most striking dissonance here comes from the different formatting...

Cool. Just that it is the other way around, isn't it? The first relabels OM into the old (client_golang) behavior, while the second relabels old (client_golang) behavior into OM. (Note...

What `%g` precisely does depends on the language/implementation. In Go, it does not add `.0` to floats with an integer value.

> It would be worth OM documenting whatever it expects languages to do, probably without reference to "Go %g". > It would be worth Prom documenting what count_values does, without...

I've just checked it out: It uses `strconv.FormatFloat(s.V, 'f', -1, 64))`, which boils down to `%f` with as many significant digits to create a unique value. And that's rather unfortunate....