Björn Rabenstein

So, in summary, I think we have to crack to nuts here: 1. How to deal with the "not enough samples in the range" warning/annotation. 2. How to implement the...

Here some rough ideas how to approach the problem. Happy to discuss here or in a call to refine. - Let's make the `annotation.Annotations` type the only thing we hand...

I'm back from vacation, and I'll review this ASAP. Have you found out anything about the Prometheus stability guarantees for the API? Can we just add another key to the...

Summarizing here from various Slack conversation: It seems adding a new key (like `info`) would be considered to be a compatible change. The question still remains if we want that...

Here my thoughts about adding position info: [Here](https://github.com/prometheus/prometheus/blob/d73b4acb301df244eacb0d50189096abc177bd07/promql/parser/parse.go#L122) is the the definition of a `ParseErr`. It contains a field of type `parser.PositionRange` and the whole `Query` as a string. It...

In this case, you could use the `args` arg. Let's assume `annotations.NewInvalidQuantileWarning` would have a `parser.PositionRange` argument, then you could write: ```Go annos.Add(annotations.NewInvalidQuantileWarning(q, args[0].PositionRange())) ``` That's the easy part, as...

Wild thought: Maybe we could store the query string once per `Annotations` (make it a struct with the current map and the new string as field). `Annotations` should always be...

> Now it looks like PromQL warning: quantile value should be between 0 and 1, not 50.00 (at 19:21). It would be cool to keep the syntax consistent with the...

I guess the formatting with the position info at the end is generally OK. (I don't think that the formatting of the parser errors is optimal, anyway – so maybe...

As pointed out by @fpetkovski in [a PR comment](https://github.com/prometheus/prometheus/pull/12188#issuecomment-1493283027), we actually don't need any new function. `histogram_quantile(1, metric)` and `histogram_quantile(0, metric)` is already doing what we want. We should just...