Björn Rabenstein

Results 1096 comments of Björn Rabenstein

I think we could just list this with a short comment like "a more lightweight alternative to the official Go instrumentation library". However, a the discussion at the team meeting...

I should probably mention that I haven't really reviewed @pascaldekloe's instrumentation library in detail. I think the discussion if we should generally consider listing more than one solution for any...

Alternative is to keep disallowing empty MetricFamilies. But we should clearly document that requirement. `metrics.proto` does not (and cannot) specify the requirement.

After ingestion, they will still not be visible (for as long as the Prometheus server doesn't handle meta data). But we can allow it in the exposition formats (and then,...

Filed https://github.com/prometheus/docs/issues/544 for the decision and documentation. Once that is settled, we change the implementation as required to resolve this issue.

Yeah, the implementation of this will be straight forward, obviously. The devil is in the detail of how to design the interface. I'm currently considering a separate `registry` package, inspired...

I mostly assigned this to myself as a “default” because I used to be the maintainer of this repo. Therefore, I'm un-assigning this from myself no. New maintainers @bwplotka &...

Yeah, that's confusing indeed. I don't know what I thought when I wrote that. I'll try to improve the wording.

I mostly assigned this to myself as a “default” because I used to be the maintainer of this repo. Therefore, I'm un-assigning this from myself no. New maintainers @bwplotka &...

I think it's fine for simple cases (like examples ;) but discouraged for more complex cases. If we make that clearer, we might be able to stick with simple examples.