tasmocompiler icon indicating copy to clipboard operation
tasmocompiler copied to clipboard

xversion: Allow selecting sensors individually

Open drhideg opened this issue 4 years ago • 10 comments

drhideg avatar Feb 06 '21 22:02 drhideg

This looks really nice! Give me time to check it.

benzino77 avatar Feb 08 '21 08:02 benzino77

As you need. The only oddity I know is with the USE_DISPLAY_ILI9342 for the M5Stack. I add it as feature, but now limited the usage to esp32 without odroid. I cant compile on esp8266 :/

drhideg avatar Feb 08 '21 08:02 drhideg

Have a look here (this is just a concept but you will see the idea). https://codesandbox.io/s/solitary-sunset-b1e1s?file=/demo.js

I think that features should be "more compact". Now it is a long, long list of features. There should be a "header" with the select all in this group, and eventually when someone needs to customize this group one could expand the group and select features which are needed.

benzino77 avatar Feb 08 '21 09:02 benzino77

It looks much better. Can you put them together?

drhideg avatar Feb 08 '21 09:02 drhideg

Put them together?

benzino77 avatar Feb 08 '21 09:02 benzino77

I mean modify the rendering part of the code. It is enough for me to just give inspiration to create better things.

drhideg avatar Feb 08 '21 09:02 drhideg

ILI9342 is... only supported on ESP32? At least it looks like. Maybe we should ask @ascillato or @Jason2866.

benzino77 avatar Feb 08 '21 09:02 benzino77

Let's move forward step by step to finally reach the moment when we both agree that this is what we want to see in new version of TC.

benzino77 avatar Feb 08 '21 11:02 benzino77

ILI9342 is... only supported on ESP32? At least it looks like. Maybe we should ask @ascillato or @Jason2866.

I don't have that display for testing it with ESP8266, but checking the code driver there isn't any exlusion for ESP8266.

ascillato avatar Feb 08 '21 11:02 ascillato

I don't have that display for testing it with ESP8266, but checking the code driver there isn't any exlusion for ESP8266.

It's true, but it trows nasty error on esp8266 (and compiles well on esp32):

Linking .pio/build/firmware/firmware.elf
/home/benzino/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: .pio/build/firmware/src/tasmota.ino.cpp.o:(.text._Z20ILI9341_2_InitDriverv+0x18): undefined reference to `ILI9341_2::ILI9341_2(signed char, signed char, signed char, signed char, signed char, signed char, signed char)'
/home/benzino/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: .pio/build/firmware/src/tasmota.ino.cpp.o:(.text._Z20ILI9341_2_InitDriverv+0x1c): undefined reference to `ILI9341_2::init(unsigned short, unsigned short)'
/home/benzino/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: .pio/build/firmware/src/tasmota.ino.cpp.o: in function `ILI9341_2_InitDriver()':
tasmota.ino.cpp:(.text._Z20ILI9341_2_InitDriverv+0x17d): undefined reference to `ILI9341_2::ILI9341_2(signed char, signed char, signed char, signed char, signed char, signed char, signed char)'
/home/benzino/.platformio/packages/toolchain-xtensa/bin/../lib/gcc/xtensa-lx106-elf/4.8.2/../../../../xtensa-lx106-elf/bin/ld: tasmota.ino.cpp:(.text._Z20ILI9341_2_InitDriverv+0x192): undefined reference to `ILI9341_2::init(unsigned short, unsigned short)'
collect2: error: ld returned 1 exit status
*** [.pio/build/firmware/firmware.elf] Error 1

benzino77 avatar Feb 08 '21 11:02 benzino77