benyamin-codez

Results 30 comments of benyamin-codez

I looked at `queue` as an alternative too. It would certainly be more elegant. I didn't go with it because at the time I wasn't sure it would have solved...

Yeah, I have approx 215 subs in my feed - not sure if that would be considered "large" though... I guess "large" is a bit like "soon" and somewhat subjective....

> The second problem is that some threads are closing in a timely manner, but others are not. The flood of connections may be causing your network to choke or...

Thanks for the explanation @MoojMidge. I see there's been some further improvements in that section of code since the pull you referenced (#478), such as the timeout tupple on the...

My understanding is that `requests` now requires `urllib3`. If you look at _script.module.requests/lib/requests/__init__.py_ you will see it imports `urllib3` and _script.module.requests/lib/requests/adapters.py_ utilises a `urllib3.poolmanager` to instantiate the `HTTPAdapter`. Unfortunately, I...

FYI, "final" diff: ```diff --- ./plugin.video.youtube-7.0.2.2.matrix.1_release/resources/lib/youtube_plugin/youtube/client/youtube.py +++ ./plugin.video.youtube-7.0.2.2.matrix.1_wip/resources/lib/youtube_plugin/youtube/client/youtube.py @@ -17,6 +17,8 @@ import requests +from time import sleep +from urllib3.util import Retry from .login_client import LoginClient from ..youtube_exceptions import YouTubeException...

> A large number of threads are spawned all at once, possibly hitting the per process thread limit based on how much system memory you have and max thread stack...

Ok, so using `concurrent.futures.ThreadPoolExecutor()` I wasn't able to reproduce the problem using the default values for the `concurrent.futures.ThreadPoolExecutor._max_workers property`, which is 8 on a Raspberry Pi 3 B+, nor with...

I should probably point out the limitations. Importantly, I used the `submit()` method rather than `map()` so results are not returned in order, but as they finish. The reason for...

Update for v7.0.3.2: ```diff --- plugin.video.youtube-7.0.3.2_release/resources/lib/youtube_plugin/youtube/client/youtube.py +++ ThreadPool_XML_Fetch_7.0.3.2_release/resources/lib/youtube_plugin/youtube/client/youtube.py @@ -11,6 +11,7 @@ from __future__ import absolute_import, division, unicode_literals import threading +import concurrent.futures import xml.etree.ElementTree as ET from copy import deepcopy...