Ben Wishovich comments

Results 95 comments of


                                            Ben Wishovich

`diagnostic::on_unimplemented` for fundamental traits, providing better compile-time errors

I don’t see an issue bumping msrv for the 0.8 release, which should be out soonTM. Perhaps push to the leptos_0.8 branch On Wed, Feb 5, 2025, at 5:27 PM,...

Bug Report: "NotFound" Error When Running `cargo leptos serve` on Workspace Example

> Cloned your repo and ran `cargo leptos serve`. I don't see any errors or logs. > > Could you clarify which `cargo leptos --version` you are using? Guessing this...

Improvements around custom error handling in ServerFnError

I think there are some nice utilities here. Originally I had meant the server_fn_error! macro to convert Error into ServerFnError depending on the traits Error implemented. I suspect that can...

fix: improve CI workflow

@sabify Looks like you have conflicts here, appreciate you taking the time to add CI to 0.6 branch

fix: improve CI workflow

Thanks!

When using the leptos-use with feature 'ssr', the compilation cannot be passed.

@tqq1994516 @itowlson Noting here that the spin_sdk is still on 2. Do you recommend updating to 3?

Add leptos extension

Yay, thanks @probably-neb! I feel a little better knowing it needs a Zed change to work. Next up if we get autotags we'll be set! On Thu, May 15, 2025,...

Replace `try_get()` with `get()` in several trait implementations for signals

Copied from the other one you've opened, so apologies if you read that one first. Feel free to reply to either one Overall I think using .try_get() is a decent...

Replace `try_get()` with `get()` in several trait implementations for signals

> Sorry for the duplicated commit history. I wrote (#3582) based on the changes here. Although this PR includes some newer commits not present in the later PR. Generally, I...

Replace `try_get()` with `get()` in several trait implementations for signals

Overall I like it, although I'd definitely want @gbj to review it as this is definitely his domain. The error message itself should probably match whatever we show in the...