win95-media-player
win95-media-player copied to clipboard
Changed imports to ESM
Thanks for the PR, however I'm not sure why it was needed. Could you please explain with some text instead of just opening a PR with no comment ? Otherwise it will be closed. Thanks for understanding.
Oh i thought you will be inactive on this repo. So I created a new repo and published an npm package.
Actually I was using it in a create-react-app and I was getting an error saying
ES Modules may not assign module.exports or exports
So I converted common js modules to esm in this package.
Let me know if I can create a new pull request with updated code from my repo.
By the way I updated this package and added some more props for my use case.
Here is the link: https://www.npmjs.com/package/win95-media-player-esm
I'm not sure I understand the context for create react app. What version are you using? Have you done any custom configuration? Normally webpack should support commonjs modules, although perhaps a new update removed this support?
I am using React 18. I didn't add any custom config. I just installed it and it was throwing error. So I had to update
Don't merge this pull request.
I didn't mean to open this pull request. It was accidental.
I just cloned the repo and updated everything which I needed in that repo and published on npm.
This is the repo I worked in. https://github.com/mhm13dev/win95-media-player-esm