react-gif-player icon indicating copy to clipboard operation
react-gif-player copied to clipboard

Published 20 hours ago • verified publisher icon benwiley4000

React 17 update?

Open pwnedev opened this issue 2 years ago • 4 comments

Hey there!

Are you going to update this package to work with react 17?

Thanks in advance!

pwnedev avatar Jan 17 '22 17:01 pwnedev

Or even react 18 at this point

derekantrican avatar Dec 07 '23 22:12 derekantrican

I think it works with any react version, is npm refusing to install because of the peer dependency?

benwiley4000 avatar Dec 07 '23 22:12 benwiley4000

I've created a PR to update for React 18: https://github.com/benwiley4000/react-gif-player/pull/39. Didn't support 17 tho, but feel free to comment on it.

@benwiley4000 The v0.4.2 built files did work with React 18, but the whole build/dev pipeline didn't, which makes it difficult to install in another project, so I made quite a few upgrades to the dependencies too.

taktran avatar Jan 24 '24 11:01 taktran

Thanks, I responded in the PR.

On Wed, Jan 24, 2024 at 6:52 AM Tak Tran @.***> wrote:

I've created a PR to update for React 18: #39 https://github.com/benwiley4000/react-gif-player/pull/39. Didn't support 17 tho, but feel free to comment on it.

@benwiley4000 https://github.com/benwiley4000 The v0.4.2 built files did work with React 18, but the whole build/dev pipeline didn't, which makes it difficult to install in another project, so I made quite a few upgrades to the dependencies too.

— Reply to this email directly, view it on GitHub https://github.com/benwiley4000/react-gif-player/issues/37#issuecomment-1907976581, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHOD3M4JMDQJG7NZZ2JEP3YQDYXFAVCNFSM5MFHMEXKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJQG44TONRVHAYQ . You are receiving this because you were mentioned.Message ID: @.***>

benwiley4000 avatar Jan 24 '24 14:01 benwiley4000