Ben Weintraub
Ben Weintraub
@Mongey would you mind taking a look when you have a moment?
> Why have special support for setting a bearer token vs just allowing setting of headers? The main reason was that it's easier to inject the bearer token (which is...
I opened https://github.com/Mongey/terraform-provider-kafka-connect/pull/92 with the changes you suggested @Mongey - feel free to just pick whichever implementation you like better, depending on whether my argument above swayed you :)
@Mongey would you be open to merging this or #92 (which has the simplified version of this change that you suggested)?
Awesome, thank you!
This seems directly related to #41. FWIW, I have a [PR](https://github.com/ricardo-ch/go-kafka-connect/pull/41) against the underlying Kafka Connect client library that adds the ability for it to pass along arbitrary headers (which...
Tracing this down a bit more in the Sarama code, it looks like the hang happens [here](https://github.com/Shopify/sarama/blob/main/offset_manager.go#L588) in `PartitionOffsetManager.Close`: ```go func (pom *partitionOffsetManager) Close() error { pom.AsyncClose() var errors ConsumerErrors...
FWIW, I've found that the following sequence works when closing a POM/OM, regardless of the `AutoCommit.Enable` state: ``` pom.AsyncClose() err = om.Close() ... handle err ... err = pom.Close ......
This would be really helpful for running tools that are CloudSQL-proxy unaware (for example, `mysqldump`) in Kubernetes with a CloudSQL proxy sidecar. In this case, I want to block `mysqldump`...
> Do you think our HTTP healthchecks would fit the bill? We have startup, liveness, and readiness. In particular the startup probe might be the right one to try. Ah,...